Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flatcar vagrant for Kubernetes 1.26 #1392

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

ccojocar
Copy link
Contributor

Fix flatcar vagrant for Kubernetes 1.26

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes the vagrant for Flatcar Linux to work with Kubernetes 1.26 which requires containerd 1.6.x which is only available in Flatcar sable stream.

Also we have to use a temporary vagrant box because there was still an issue with ssh which was fixed by Flatcar but not yet released.

See for details: flatcar/Flatcar#916

Which issue(s) this PR fixes:

Fixes #1377

Does this PR have test?

Yes

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix vagrant for Flatcar Linux to work with Kubernetes 1.26.

A temporary box needs to be used until Flatcar will release of new version of stable.

See flatcar/Flatcar#916
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Dec 22, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2022
@ccojocar
Copy link
Contributor Author

/assign @saschagrunert @jhrozek

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #1392 (2ff4614) into main (9108c0a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1392   +/-   ##
=======================================
  Coverage   44.21%   44.21%           
=======================================
  Files          50       50           
  Lines        5640     5640           
=======================================
  Hits         2494     2494           
  Misses       3026     3026           
  Partials      120      120           

@ccojocar
Copy link
Contributor Author

/test e2e-flatcar

@k8s-ci-robot
Copy link
Contributor

@ccojocar: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-security-profiles-operator-build
  • /test pull-security-profiles-operator-build-image
  • /test pull-security-profiles-operator-test-e2e
  • /test pull-security-profiles-operator-test-unit
  • /test pull-security-profiles-operator-verify

Use /test all to run all jobs.

In response to this:

/test e2e-flatcar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ccojocar
Copy link
Contributor Author

/test pull-security-profiles-operator-test-e2e

@ccojocar
Copy link
Contributor Author

/test all

@ccojocar ccojocar force-pushed the fix-flatcar-e2e-kube-1.26 branch from ac28747 to 2ff4614 Compare December 23, 2022 10:36
@JAORMX
Copy link
Contributor

JAORMX commented Dec 23, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, JAORMX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6613546 into kubernetes-sigs:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatcar VM bootstrap fails
6 participants