-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the priority class name configurable in the SPOD configuration #1488
Make the priority class name configurable in the SPOD configuration #1488
Conversation
/assign @saschagrunert |
/test e2e-flatcar |
@ccojocar: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
==========================================
- Coverage 43.98% 43.98% -0.01%
==========================================
Files 50 50
Lines 5715 5716 +1
==========================================
Hits 2514 2514
- Misses 3080 3081 +1
Partials 121 121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thank you for the enhancement!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Make the priority class name configurable in the SPOD configuration, and it sets the default value to
system-node-critical
.This is useful when the spod daemon pod remains in
Pending
state because there isn't enough capacity on the related not to be scheduled.Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?