Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spoc, the Security Profiles Operator CLI #1490

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

We discussed in our last sync meeting that it would be helpful to have a slimmer SPO CLI for faster execution in edge scenarios. For that we would need a new binary, which can be used to directly interact with features like the ebpf recorder.

Which issue(s) this PR fixes:

Refers to #1482

Does this PR have test?

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added `spoc` binary, the Security Profiles Operator CLI. This new binary is also part of the default container images.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2023
@saschagrunert saschagrunert force-pushed the spoc branch 7 times, most recently from 42b10e4 to f5d1b5f Compare February 20, 2023 14:12
We discussed in our last sync meeting that it would be helpful to have a
slimmer SPO CLI for faster execution in edge scenarios. For that we
would need a new binary, which can be used to directly interact with
features like the ebpf recorder.

Refers to kubernetes-sigs#1482

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

@kubernetes-sigs/security-profiles-operator-maintainers PTAL

Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the name!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
@JAORMX
Copy link
Contributor

JAORMX commented Feb 20, 2023

/lgtm cancel
Let's let other maintainers look at this first

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
Copy link
Contributor

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

How do you envision the workflow of using the CLI? Does one need to run the spoc container on the same host next to another container for which the recording is performed? Is additionally required the existing recorder container which communicates over gRCP with spoc container, or does it get merged into spoc CLI container?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, JAORMX, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JAORMX,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b0098fd into kubernetes-sigs:main Feb 20, 2023
@saschagrunert saschagrunert deleted the spoc branch February 21, 2023 07:51
@saschagrunert
Copy link
Member Author

How do you envision the workflow of using the CLI? Does one need to run the spoc container on the same host next to another container for which the recording is performed?

No, my main idea was to provide 2 distinct sets of functionality:

  • Doing something without having a need for kubernetes at all, means that there is also no operator deployed
  • Having sort of client interface to the operator

Means we can start with the first one and trying to integrate bpf recording of executables. Later on we can use the same binary for other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants