Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base syscalls for spoc recording #1510

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows to have a preset of defined syscalls required as a minimum to run containers with runc and crun.

Which issue(s) this PR fixes:

Part of #1482

Does this PR have test?

Yes

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added `--base-syscalls` to `spoc record` to ensure compatibility with OCI runtimes like runc and crun.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2023
@saschagrunert saschagrunert force-pushed the base-syscalls branch 3 times, most recently from 5ed51fa to d6eb799 Compare February 28, 2023 15:24
@codecov-commenter
Copy link

Codecov Report

Merging #1510 (860eae5) into main (ef25024) will decrease coverage by 0.08%.
The diff coverage is 21.42%.

❗ Current head 860eae5 differs from pull request most recent head d6eb799. Consider uploading reports for the commit d6eb799 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   43.32%   43.24%   -0.08%     
==========================================
  Files          53       53              
  Lines        5904     5917      +13     
==========================================
+ Hits         2558     2559       +1     
- Misses       3225     3236      +11     
- Partials      121      122       +1     

@saschagrunert saschagrunert force-pushed the base-syscalls branch 3 times, most recently from cc2a3c3 to 24a76d1 Compare February 28, 2023 15:30
This allows to have a preset of defined syscalls required as a minimum
to run containers with runc and crun.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

@kubernetes-sigs/security-profiles-operator-maintainers PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JAORMX,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 93eed48 into kubernetes-sigs:main Mar 2, 2023
@saschagrunert saschagrunert deleted the base-syscalls branch March 2, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants