Add OCI baseprofile support #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
oci-baseprofiles
branch
3 times, most recently
from
b19b19f to
b45c90f
Compare
k8s-ci-robot
added
size/L
saschagrunert
force-pushed
the
oci-baseprofiles
branch
2 times, most recently
from
28fcfde to
e367910
Compare
|
/test pull-security-profiles-operator-verify |
ccojocar
approved these changes
Mar 21, 2023
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
Blocked by kubernetes/org#4105 |
saschagrunert
force-pushed
the
oci-baseprofiles
branch
from
e367910 to
e340cf5
Compare
k8s-ci-robot
removed
the
lgtm
saschagrunert
force-pushed
the
oci-baseprofiles
branch
2 times, most recently
from
9cc7be9 to
759b856
Compare
|
/test pull-security-profiles-operator-verify |
saschagrunert
force-pushed
the
oci-baseprofiles
branch
3 times, most recently
from
ecfc5d1 to
8ae1a5e
Compare
|
/retest |
1 similar comment
|
/retest |
saschagrunert
force-pushed
the
oci-baseprofiles
branch
2 times, most recently
from
d7456d6 to
3caf633
Compare
saschagrunert
changed the title
k8s-ci-robot
added
size/XXL
saschagrunert
force-pushed
the
oci-baseprofiles
branch
from
3caf633 to
73d4594
Compare
|
@kubernetes-sigs/security-profiles-operator-maintainers PTAL |
|
/test pull-security-profiles-operator-test-e2e |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
==========================================
+ Coverage 48.67% 49.00% +0.32%
==========================================
Files 68 69 +1
Lines 6664 6744 +80
==========================================
+ Hits 3244 3305 +61
- Misses 3295 3314 +19
Partials 125 125 |
saschagrunert
force-pushed
the
oci-baseprofiles
branch
from
21b7ede to
fdc0c98
Compare
This allows using OCI artifacts as base profiles when the baseProfileName is prefixed with `oci://`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
oci-baseprofiles
branch
from
fdc0c98 to
850c71b
Compare
ccojocar
approved these changes
Mar 30, 2023
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows using OCI artifacts as base profiles when the
baseProfileNameis prefixed withoci://.Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?