-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patching container ID discovery to support DiD #1648
Conversation
Signed-off-by: Ben <ben@armosec.io>
|
Welcome @slashben! |
Hi @slashben. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you for the PR @slashben, may I ask you to sign the CLA? |
@saschagrunert done I see that for some reason the image was not built but I don't really see why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, slashben The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What type of PR is this?
/kind bug
What this PR does / why we need it:
eBPF recorder is failing on minikube with the docker driver, this fix enables support parsing docker in docker /proc/pid/cgroup strings
Which issue(s) this PR fixes:
Fixes #1249
Does this PR have test?
I haven't found an existing test to extend