-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCI artifact platform support #1658
Conversation
d206583
to
eb99a6f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
+ Coverage 48.58% 49.34% +0.75%
==========================================
Files 69 71 +2
Lines 6788 6929 +141
==========================================
+ Hits 3298 3419 +121
- Misses 3358 3380 +22
+ Partials 132 130 -2 |
@kubernetes-sigs/security-profiles-operator-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, otherwise lgtm.
This allows pushing and pulling multiple platforms as OCI artifacts. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Thank you @pjbgf, I addressed all the comments. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows pushing and pulling multiple platforms as OCI artifacts.
Which issue(s) this PR fixes:
Refers to #1482
Does this PR have test?
Yes
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?