Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime to v0.15.0 and it's Kubernetes dependencies #1700

Merged
merged 2 commits into from
May 25, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

None

Does this PR have test?

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated controller-runtime to v0.15.0.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2023
@saschagrunert saschagrunert changed the title Update controller-runtime to v0.15.0 and it's Kubernetes dependencies WIP: Update controller-runtime to v0.15.0 and it's Kubernetes dependencies May 24, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@k8s-ci-robot k8s-ci-robot requested review from JAORMX and Vincent056 May 24, 2023 07:44
@saschagrunert saschagrunert force-pushed the controller-runtime branch 3 times, most recently from 45d8978 to bff87e3 Compare May 24, 2023 08:25
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #1700 (48fc86d) into main (a772f4f) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   49.35%   49.20%   -0.15%     
==========================================
  Files          71       71              
  Lines        6930     6950      +20     
==========================================
  Hits         3420     3420              
- Misses       3380     3400      +20     
  Partials      130      130              

@saschagrunert saschagrunert changed the title WIP: Update controller-runtime to v0.15.0 and it's Kubernetes dependencies Update controller-runtime to v0.15.0 and it's Kubernetes dependencies May 24, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@saschagrunert saschagrunert changed the title Update controller-runtime to v0.15.0 and it's Kubernetes dependencies WIP: Update controller-runtime to v0.15.0 and it's Kubernetes dependencies May 24, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@saschagrunert saschagrunert force-pushed the controller-runtime branch 2 times, most recently from f1bc4f3 to 48fc86d Compare May 24, 2023 10:31
@saschagrunert saschagrunert changed the title WIP: Update controller-runtime to v0.15.0 and it's Kubernetes dependencies Update controller-runtime to v0.15.0 and it's Kubernetes dependencies May 24, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@saschagrunert saschagrunert force-pushed the controller-runtime branch 6 times, most recently from 7bb1a54 to 4d0970f Compare May 25, 2023 08:01
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Finally green tests, PTAL @kubernetes-sigs/security-profiles-operator-maintainers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JAORMX,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87f6c44 into kubernetes-sigs:main May 25, 2023
@saschagrunert saschagrunert deleted the controller-runtime branch May 25, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants