Fix for selinux policy constantly being processed

[novaesis]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Sorts the allow rules in the selinux policy when doing the write to the node and doing the comparison between CRD and node policy which allows for consistent comparisons.

Which issue(s) this PR fixes:

Fixes #1842

Does this PR have test?

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed selinux policy constantly being processed.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: novaesis / name: Nathan (6b0f54f, 6666dfc, 09c6f05, e8e26dc)

[k8s-ci-robot]

Welcome @novaesis!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @novaesis. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhrozek]

/ok-to-test

[jhrozek]

/lgtm
really nice work, thank you. Let's see if the tests pass!

[codecov-commenter]

Codecov Report

Merging #1843 (e8e26dc) into main (f8fab34) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 23.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
- Coverage   49.23%   49.18%   -0.05%     
==========================================
  Files          71       72       +1     
  Lines        7024     7030       +6     
==========================================
  Hits         3458     3458              
- Misses       3432     3438       +6     
  Partials      134      134              

[saschagrunert]

CI complains about:

1 files have incorrect boilerplate headers:
internal/pkg/util/maps.go

[novaesis]

@saschagrunert fixed the issue the CI was complaint about. The other two build issues appear not related to this PR.

[saschagrunert]

Thank you!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, novaesis, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhrozek,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment