-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fileDescriptor memory leak #1879
Fix fileDescriptor memory leak #1879
Conversation
Hi @CoreyCook8. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
886c05b
to
99fec73
Compare
/ok-to-test |
7106745
to
c0fba47
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1879 +/- ##
=======================================
Coverage 49.21% 49.22%
=======================================
Files 72 72
Lines 7034 7033 -1
=======================================
Hits 3462 3462
+ Misses 3438 3437 -1
Partials 134 134 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CoreyCook8, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
This PR creates only one http client and reuses it rather than making a new client every time.
Which issue(s) this PR fixes:
fixes #1878
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?