Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kube-rbac-proxy v0.15.0 and disable HTTP/2 #1940

Merged

Conversation

yuumasato
Copy link
Contributor

@yuumasato yuumasato commented Oct 27, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Use kube-rbac-proxy-image v0.15.0 and use the flag that disables HTTP/2.
Disabling HTTP/2 mitigates a rapid reset vulnerability in HTTP/2 protocol.

Which issue(s) this PR fixes:

This update is part of strategy to mitigate HTTP/2 rapid reset vulnerability.

Does this PR have test?

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Updated kube-rbac-proxy to v0.15.0.
- Disable kube-rbac-proxy HTTP/2 support 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yuumasato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2023
@yuumasato yuumasato changed the title Use kube-rback-proxy v0.15.0 and disable HTTP/2 Use kube-rbac-proxy v0.15.0 and disable HTTP/2 Oct 27, 2023
@Vincent056
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1940 (82f975e) into main (edb34ac) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1940   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files          72       72           
  Lines        7037     7037           
=======================================
  Hits         3466     3466           
  Misses       3437     3437           
  Partials      134      134           

@yuumasato yuumasato force-pushed the update-kube-rbac-proxy-image branch from 82f975e to ab4fe33 Compare October 30, 2023 12:00
@Vincent056
Copy link
Contributor

/ok-to-test

@yuumasato yuumasato force-pushed the update-kube-rbac-proxy-image branch from ab4fe33 to 1741bac Compare October 30, 2023 20:12
@pjbgf
Copy link
Member

pjbgf commented Oct 31, 2023

/ok-to-test

@Vincent056
Copy link
Contributor

/retest

Disabling HTTP/2 mitigates a rapid reset vulnerability in HTTP/2
protocol.
@yuumasato yuumasato force-pushed the update-kube-rbac-proxy-image branch from 1741bac to 86db7ec Compare November 15, 2023 10:20
@yuumasato
Copy link
Contributor Author

Rebased to pickup CI changes on main

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1e852d3 into kubernetes-sigs:main Nov 15, 2023
19 checks passed
@yuumasato yuumasato deleted the update-kube-rbac-proxy-image branch November 15, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants