fix: dynamic clusters sometimes encounter a finalizer mismatch

[jlowe64]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR attempts to fix an issue with dynamically scaling clusters, such as ones using Karpenter, where the number of nodes can remain the same while the contents of the profile's finalizers may differ. This will result in not being able to manage the profile without interacting with the finalizers directly.

Which issue(s) this PR fixes:

None

Does this PR have test?

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

fix: dynamic clusters encounter finalizer mismatch when nodes are added and removed too quickly

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jlowe64 / name: Jerrett Fowler (320ad52, 7de0540, aafcbd8, fe7d710, 1d78530, 7010244, 4a15ae3, 815d42c, 28773da, a83aa25, 9c8a22c, 2737d74, 9ee8539, 616ddbf)

[k8s-ci-robot]

Welcome @jlowe64!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jlowe64. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[saschagrunert]

Thank you for the PR @jlowe64! Do you mind signing the CLA?

[jlowe64]

Thank you for the PR @jlowe64! Do you mind signing the CLA?

I did this earlier, I was just waiting on someone from my team to tell me how our company handles open source contributions! Thank you.

Also, could you please hold off on approving the automated tests (I believe you have to approve them), I need to push to my fork cause I'm doing testing on a linux workstation and need to commit in order to run tests. I'll poke you on here when I want the tests to be run. I don't want to waste your resources when I am fixing issues from the tests!

[saschagrunert]

/ok-to-test

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 40.99%. Comparing base (11d77f4) to head (9ee8539).
Report is 182 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   45.50%   40.99%   -4.51%     
==========================================
  Files          79      108      +29     
  Lines        7782    15583    +7801     
==========================================
+ Hits         3541     6389    +2848     
- Misses       4099     8724    +4625     
- Partials      142      470     +328     

[jlowe64]

I'm not ready to merge this, I need to look at it some more.

[ccojocar]

I think there is an util.Contains function already for this.

[jlowe64]

@ccojocar I am doing something slightly different in that I'm not looking for an equality of strings, but rather if a substring is contained within a string. I looked at your function and I've matched the naming convention of what you have for util.Contains, by calling it util.ContainsSubstring.

[saschagrunert]

Suggested change

	Copyright 2020 The Kubernetes Authors.
	Copyright 2024 The Kubernetes Authors.

[k8s-ci-robot]

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ccojocar]

Thanks, it looks good!

[saschagrunert]

Is this still WIP @jlowe64 ?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jlowe64, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ccojocar,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlowe64]

Is this still WIP @jlowe64 ?

I have just removed the WIP tag.