-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppArmor: support path globs when merging profiles #2239
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2239 +/- ##
==========================================
- Coverage 45.50% 41.42% -4.08%
==========================================
Files 79 108 +29
Lines 7782 15587 +7805
==========================================
+ Hits 3541 6457 +2916
- Misses 4099 8664 +4565
- Partials 142 466 +324 |
/test all |
@mhils please rebase on top of |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like CI failure are unrelated to the PR and need a restart. :) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR makes
spoc merge
understand glob patterns in the profile. This improves the UX when merging automatically recorded profiles into hand-maintained ones:$ cat demo.yml apiVersion: security-profiles-operator.x-k8s.io/v1alpha1 kind: AppArmorProfile spec: abstract: executable: allowedExecutables: - /sbin/ip{,6}tables-save $ cat recorded.yml apiVersion: security-profiles-operator.x-k8s.io/v1alpha1 kind: AppArmorProfile spec: abstract: executable: allowedExecutables: - /sbin/iptables-save - /sbin/ip6tables-save $ build/spoc merge demo.yml recorded.yml 20:14:27.951272 Merging 2 profiles into /tmp/profile.yaml 20:14:27.951288 Reading file demo.yml 20:14:27.951582 Reading file recorded.yml $ cat /tmp/profile.yaml apiVersion: security-profiles-operator.x-k8s.io/v1alpha1 kind: AppArmorProfile metadata: creationTimestamp: null spec: abstract: executable: allowedExecutables: - /sbin/ip{,6}tables-save. # no new entries status: {}
Which issue(s) this PR fixes:
None
Does this PR have test?
Yes.
Special notes for your reviewer:
Does this PR introduce a user-facing change?