-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spoc merge
: add --check
#2240
spoc merge
: add --check
#2240
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2240 +/- ##
==========================================
- Coverage 45.50% 41.12% -4.38%
==========================================
Files 79 107 +28
Lines 7782 15540 +7758
==========================================
+ Hits 3541 6391 +2850
- Misses 4099 8678 +4579
- Partials 142 471 +329 |
Fixing the CI in #2242 |
/test all |
@mhils please rebase on top of |
this flag is useful to ensure in CI that the profile includes all capabilities exercised in tests
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a
--check
flag to spoc merge. This can be used to ensure that (automatically generated) profiles are subsets of a (hand-authored) profile in CI. This is better than manually callingdiff
as we ignore non-essential syntax such as comments.Which issue(s) this PR fixes:
None
Does this PR have test?
Not yet.
Special notes for your reviewer:
Does this PR introduce a user-facing change?