-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make the webhook tolerations configurable #892
fix: make the webhook tolerations configurable #892
Conversation
Hi @ccojocar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test all |
/test pull-security-profiles-operator-test-e2e |
/test all |
5b24fd0
to
f9b9ee6
Compare
Codecov Report
@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 50.99% 50.98% -0.02%
==========================================
Files 42 42
Lines 4536 4537 +1
==========================================
Hits 2313 2313
- Misses 2142 2143 +1
Partials 81 81 |
/test all |
4fc0ee2
to
685be30
Compare
/test all |
70ede81
to
fc2b176
Compare
/test all |
d4a1307
to
fc2b176
Compare
/test all |
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
fc2b176
to
56db33d
Compare
/test all |
1 similar comment
/test all |
@saschagrunert This pull request needs again a lgtm. Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Cosmin Cojocar gcojocar@adobe.com
What type of PR is this?
What this PR does / why we need it:
It makes the tolerations of the webhook configurable via the SPOD configuration. We have policies which prevents the scheduling of pods on master nodes. This change will allow us to change the default tolerations of the webhook which violates our security policy.
Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?