Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the webhook tolerations configurable #892

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

ccojocar
Copy link
Contributor

@ccojocar ccojocar commented Apr 11, 2022

Signed-off-by: Cosmin Cojocar gcojocar@adobe.com

What type of PR is this?

What this PR does / why we need it:

It makes the tolerations of the webhook configurable via the SPOD configuration. We have policies which prevents the scheduling of pods on master nodes. This change will allow us to change the default tolerations of the webhook which violates our security policy.

Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Makes the tolerations of the webhook configurable via the SPOD configuration

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ccojocar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 11, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2022
@saschagrunert
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2022
@ccojocar
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2022
@ccojocar
Copy link
Contributor Author

/test pull-security-profiles-operator-test-e2e

@ccojocar
Copy link
Contributor Author

/test all

@ccojocar ccojocar force-pushed the cfg-webhook-tolerations branch from 5b24fd0 to f9b9ee6 Compare April 11, 2022 12:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #892 (d4a1307) into main (ac82a2e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head d4a1307 differs from pull request most recent head fc2b176. Consider uploading reports for the commit fc2b176 to get more accurate results

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   50.99%   50.98%   -0.02%     
==========================================
  Files          42       42              
  Lines        4536     4537       +1     
==========================================
  Hits         2313     2313              
- Misses       2142     2143       +1     
  Partials       81       81              

@ccojocar
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2022
@ccojocar ccojocar force-pushed the cfg-webhook-tolerations branch from 4fc0ee2 to 685be30 Compare April 12, 2022 08:18
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2022
@ccojocar
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 12, 2022
@ccojocar ccojocar force-pushed the cfg-webhook-tolerations branch from 70ede81 to fc2b176 Compare April 13, 2022 13:43
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022
@ccojocar
Copy link
Contributor Author

/test all

@ccojocar ccojocar force-pushed the cfg-webhook-tolerations branch 2 times, most recently from d4a1307 to fc2b176 Compare April 13, 2022 14:31
@ccojocar
Copy link
Contributor Author

/test all

Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
@ccojocar ccojocar force-pushed the cfg-webhook-tolerations branch from fc2b176 to 56db33d Compare April 14, 2022 08:35
@ccojocar
Copy link
Contributor Author

/test all

1 similar comment
@ccojocar
Copy link
Contributor Author

/test all

@ccojocar
Copy link
Contributor Author

@saschagrunert This pull request needs again a lgtm. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 79bfa1d into kubernetes-sigs:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants