-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a syscall allow list in the SPOD configuration #913
Conversation
Hi @ccojocar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #913 +/- ##
==========================================
- Coverage 50.64% 50.49% -0.16%
==========================================
Files 42 42
Lines 4626 4735 +109
==========================================
+ Hits 2343 2391 +48
- Misses 2198 2259 +61
Partials 85 85 |
/test build |
@ccojocar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
af3f961
to
11421df
Compare
/ok-to-test |
@ccojocar may I ask you to give this one a rebase? |
…e list of syscalls allowed in seccomp profile Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
…anged in SPOD Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
…e profile is in use Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
@saschagrunert All tests passed after rebasing, please could you have a look? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the code changes look good from what I can see.
Can we add docs to the installation and usage guide to describe the feature? I'm curious how it behaves if we change the allowed syscalls for already deployed profiles (we cannot remove them when they're in usage).
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Signed-off-by: Cosmin Cojocar <gcojocar@adobe.com>
Thanks for review @saschagrunert! I added some documentation which explains how to use the allow syscalls list.
There is an e2e test for this, namely |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
1 similar comment
/test all |
What type of PR is this?
What this PR does / why we need it:
Add a syscall allow list in the SPOD configuration. This is to allow an administrator to limit cluster-wide the syscalls which are allowed to be defined in the seccomp profiles.
Which issue(s) this PR fixes:
Fixes #897
Does this PR have test?
Yes
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Yes