Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Changed walkthrough from UPS to mini #2671

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

zulandar
Copy link
Contributor

@zulandar zulandar commented Jul 1, 2019

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

What this PR does / why we need it:
Requested change from UPS Broker to Minibroker within walkthrough.

Which issue(s) this PR fixes
Fixes #2658

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

  • New feature
    • Tests
    • Documentation
  • SVCat CLI flag
  • Server Flag for config
    • Chart changes
    • removing a flag by marking deprecated and hiding to avoid
      breaking the chart release and existing clients who provide a
      flag that will get an error when they try to update

@k8s-ci-robot
Copy link
Contributor

Welcome @zulandar!

It looks like this is your first PR to kubernetes-sigs/service-catalog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/service-catalog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2019
@jberkhahn
Copy link
Contributor

/assign @jberkhahn

docs/walkthrough.md Outdated Show resolved Hide resolved
docs/walkthrough.md Outdated Show resolved Hide resolved
docs/walkthrough.md Outdated Show resolved Hide resolved
@jberkhahn
Copy link
Contributor

mentioned a couple things, other than that this looks good

Adjusted per PR recommendations
@zulandar
Copy link
Contributor Author

zulandar commented Jul 4, 2019

mentioned a couple things, other than that this looks good

Made the recommended adjustments.

@zulandar
Copy link
Contributor Author

zulandar commented Jul 4, 2019

/retest

No code changes was performed to cause test failures. Here is the failure from the test.

Setting up ca-certificates (20161130+nmu1+deb9u1) ...
Updating certificates in /etc/ssl/certs...
/usr/sbin/update-ca-certificates: 101: /usr/sbin/update-ca-certificates: sed: Exec format error
/usr/sbin/update-ca-certificates: 75: /usr/sbin/update-ca-certificates: rm: Exec format error
dpkg: error processing package ca-certificates (--configure):
 subprocess installed post-installation script returned error exit status 2
Processing triggers for libc-bin (2.24-11+deb9u4) ...
Errors were encountered while processing:
 ca-certificates
�[91mE�[0m�[91m: Sub-process /usr/bin/dpkg returned an error code (1)
�[0mThe command '/bin/sh -c export DEBIAN_FRONTEND=noninteractive &&     apt-get update &&     apt-get install ca-certificates -y &&     rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100
Makefile:383: recipe for target 'service-catalog-image' failed
make[1]: *** [service-catalog-image] Error 100
make[1]: Leaving directory '/home/prow/go/src/github.com/kubernetes-sigs/service-catalog'
Makefile:348: recipe for target 'arch-image-arm64' failed
make: *** [arch-image-arm64] Error 2
+ EXIT_VALUE=2
+ set +o xtrace

@mszostok
Copy link
Contributor

mszostok commented Jul 8, 2019

/test pull-service-catalog-xbuild

@mszostok
Copy link
Contributor

mszostok commented Jul 8, 2019

@zulandar currently is a known issue that the pull-service-catalog-xbuild is sometimes failing with such /usr/sbin/update-ca-certificates: rm: Exec format error error you need to add comment

/test pull-service-catalog-xbuild

to execute that test one more time.

@jberkhahn
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn, zulandar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 35164fd into kubernetes-retired:master Jul 8, 2019
@zulandar zulandar deleted the issue-2658 branch July 8, 2019 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace use of UPS broker in docs walkthrough with minibroker
4 participants