-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicity disable dualstack for win overlay #147
Explicity disable dualstack for win overlay #147
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
given this is a breaking change in kube-proxy we should be fixing it in a 1.21 patch release? |
agree they should be fixed in a patch release, but win overlay isn't supported with dualstack either way. While waiting for the patch release I would rather have the tests running to catch other issues that might be introduced |
ok, understood. cancel the hold if you think this should merge now. |
PR to for fixing the patch: kubernetes/kubernetes#101047 |
Reason for PR:
1.21 broke win overlay with dualstack: kubernetes/kubernetes#100966
The kubeadm tests are broken becuase of this:
https://testgrid.k8s.io/sig-windows-master-release#kubeadm-windows-gcp-k8s-stable
Issue Fixed:
Issue #
Requirements
Notes:
/assign @marosset @neolit123