Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching files in the build phase #167

Merged

Conversation

hxietkg
Copy link
Contributor

@hxietkg hxietkg commented Sep 1, 2021

Reason for PR:
Current burrito is an empty burrito image, it downloads file in the run phase only, we need a burrito image with files already pulled. In this change a new ARG 'CONFIG_FILE' is added, which indicates the file list to be downloaded, we may pass an ARG to 'docker build':
docker build --build-arg CONFIG_FILE= ......

Issue Fixed:
N/A

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hxietkg
To complete the pull request process, please assign jayunit100 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jayunit100 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2021
@jayunit100
Copy link
Contributor

/lgtm

@jayunit100 jayunit100 merged commit f43c310 into kubernetes-sigs:master Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants