Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Move-Item parameter and iface in flannel hostprocess #194

Merged
merged 3 commits into from
Dec 15, 2021
Merged

fix Move-Item parameter and iface in flannel hostprocess #194

merged 3 commits into from
Dec 15, 2021

Conversation

djboris9
Copy link
Contributor

@djboris9 djboris9 commented Dec 14, 2021

Reason for PR:
Flannel in hostprocess mode fails with the following error:

$ kubectl -n kube-system logs -f kube-flannel-ds-windows-2022-amd64-kpnhk
Moving SDN CNI binaries to host
Move-Item : A parameter cannot be found that matches parameter name 'DestinationPath'.
At C:\C\2e81614228d3b72843d632b147666ae352759a67c6934ee8b0f058d5498ede26\flannel\start.ps1:5 char:59
+ ... th "$env:CONTAINER_SANDBOX_MOUNT_POINT/cni/" -DestinationPath "c:\opt ...
+                                                  ~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Move-Item], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.MoveItemCommand

This is because Move-Item contains no parameter named DestinationPath but has a parameter called Destination.
Also change Move-Item to Copy-Item, because the CONTAINER_SANDBOX_MOUNT_POINT access is denied (Move-Item : Access to the path 'C:\C\5058c3fcf6266d2ba0c83cb8ce7dc4270e459f9ce470807bebf3f836a3182d2b\cni\' is denied.).

Additionally the call to flanneld has a static iface IP set (10.1.0.5). This is changed now to the $managementIP.

This issue is also mentioned in #181

Issue Fixed:
Issue #181 partly

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2021
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 14, 2021
@djboris9
Copy link
Contributor Author

/assign @ddebroy

@djboris9 djboris9 marked this pull request as draft December 14, 2021 14:21
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021
@djboris9 djboris9 changed the title fix Move-Item parameter DestinationPath in flannel hostprocess fix Move-Item parameter and iface in flannel hostprocess Dec 14, 2021
@djboris9 djboris9 marked this pull request as ready for review December 14, 2021 15:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021
@jsturtevant
Copy link
Contributor

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djboris9, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 42d4411 into kubernetes-sigs:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants