Csi proxy image #203
Merged
Csi proxy image #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
github-actions
bot
added
the
tide/merge-method-squash
marosset
force-pushed
the
csi-proxy-image
branch
from
7b85b5d
to
adc13e5
Compare
|
/assign @jsturtevant |
|
This work started in kubernetes-csi/csi-proxy#179 |
jsturtevant
reviewed
Jan 13, 2022
…chagnes and correctly set version for release builds)
zhiweiv
reviewed
Jan 14, 2022
|
|
||
| FROM ${REGISTRY}/${WINDOWS_BASE_IMAGE}:${WINDOWS_VERSION} | ||
| COPY --from=builder /go/csi-proxy/bin/csi-proxy.exe /csi-proxy.exe | ||
| ENV PATH="C:\Windows\system32;C:\Windows;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;" |
There was a problem hiding this comment.
Seems the env issue mentioned in https://github.com/kubernetes/kubernetes/blob/master/build/pause/Dockerfile_windows#L26-L28 has been fixed long ago, is this sill needed?
jsturtevant
reviewed
Jan 21, 2022
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR:
This PR builds/releases a csi-proxy container image.
This image is hosted here because running csi-proxy is a short-term solution (the longterm solution is to have the plugins consume csi-proxy as a library) and csi-proxy repo did not want to maintain an official image.
Issue Fixed:
Issue #
Requirements
Notes: