Fix kubeadm/kube-proxy source VIP usage

[ionutbalutoiu]

PR Reason

The source VIP for the kubeadm/kube-proxy is not properly used.

PR Description

Remove IPv6DualStack feature gate. This is locked to true by default.

Proper kube-proxy VIP usage in kubeadm/kube-proxy manifest. Properly reserve the source VIP for kube-proxy to use.
This logic is already used in the hostprocess/flannel/kube-proxy manifest.
It was just ported to this kube-proxy daemonset, which is supposed to be used with legacy docker container runtime.

[k8s-ci-robot]

Welcome @ionutbalutoiu!

It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ionutbalutoiu
To complete the pull request process, please assign marosset after the PR has been reviewed.
You can assign the PR to them by writing /assign @marosset in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

Remove IPv6DualStack feature gate. This is locked to true by default.

LGTM, on this change as the FG went GA.
(not sure about the rest)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[rudesome]

@jsturtevant
Will this be merged anytime soon?

Getting the error on my 1.23 k8s
E0525 7944 run.go:120] "command failed" err="failed complete: cannot set feature gate IPv6DualStack to false, feature is locked to true"

[jsturtevant]

The error E0525 7944 run.go:120] "command failed" err="failed complete: cannot set feature gate IPv6DualStack to false, feature is locked to true" is not related to this PR. Modify your kubeproxy configuration (in the yaml configuration file) to remove the IPv6DualStack flag to false. Better is to remove the flag as it has been completely removed in 1.25 (current active kubernetes branch).

[ionutbalutoiu]

The error E0525 7944 run.go:120] "command failed" err="failed complete: cannot set feature gate IPv6DualStack to false, feature is locked to true" is not related to this PR. Modify your kubeproxy configuration (in the yaml configuration file) to remove the IPv6DualStack flag to false. Better is to remove the flag as it has been completely removed in 1.25 (current active kubernetes branch).

There is an extra commit to this PR that removes the feature flag: Remove IPv6DualStack feature gate

I can have a separate PR with it.

[ionutbalutoiu]

The error E0525 7944 run.go:120] "command failed" err="failed complete: cannot set feature gate IPv6DualStack to false, feature is locked to true" is not related to this PR. Modify your kubeproxy configuration (in the yaml configuration file) to remove the IPv6DualStack flag to false. Better is to remove the flag as it has been completely removed in 1.25 (current active kubernetes branch).

There is an extra commit to this PR that removes the feature flag: Remove IPv6DualStack feature gate

I can have a separate PR with it.

This is it: #224

I'll rebase this PR after that gets merged.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.