Making script more self-explanatory #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
k8s-ci-robot
added
the
cncf-cla: no
k8s-ci-robot
added
the
size/M
github-actions
bot
added
the
tide/merge-method-squash
fabi200123
force-pushed
the
Making-script-more-self-explanatory
branch
from
81fc77a
to
4dab62c
Compare
Making script more self-explanatory for users because after they join the node they also have to apply the cni daemonset/service and the kube-proxy and they have to change the k8s version of the kube-proxy.yml file to match their own.
fabi200123
force-pushed
the
Making-script-more-self-explanatory
branch
from
4dab62c
to
5efd6f0
Compare
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabi200123, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR:
Making script more self-explanatory for users because after joining the node they also have to apply the cni daemonset/service and the kube-proxy and they have to change the k8s version of the kube-proxy.yml file to match their own.
All kube-proxy.yml files in the repository have different versions of k8s set to their containers` images and the user need to manually configure them to match its own version of kubernetes.
For calico, kube-proxy image is " - image: sigwindowstools/kube-proxy:v1.22.3-calico-hostprocess"
For rancher, kube-proxy image is "image: sigwindowstools/kube-proxy:VERSION-nanoserver"
For flannel, kube-proxy image is "- image: sigwindowstools/kube-proxy:v1.22.4-flannel-hostprocess"
It is not self-explanatory and this might cause problems to users.