Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SAC releases from non-hostprocess images #253

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Dec 5, 2022

Signed-off-by: Mark Rossetti marosset@microsoft.com

Reason for PR:

All Windows SAC releases are deprecated.

Issue Fixed:

Issue #

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2022
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 5, 2022
@marosset
Copy link
Contributor Author

marosset commented Dec 5, 2022

@marosset
Copy link
Contributor Author

marosset commented Dec 5, 2022

Related to #251

@Mik4sa
Copy link
Contributor

Mik4sa commented Dec 5, 2022

Back then I tested "nanoserver-ltsc2022" for Windows Server 2022. That's the reason I added it with #205 :)

@Mik4sa
Copy link
Contributor

Mik4sa commented Dec 8, 2022

@marosset May you get this done by next week? In about one or two weeks I may need this for production and I would like to use the official images :)

@marosset
Copy link
Contributor Author

marosset commented Dec 8, 2022

@marosset May you get this done by next week? In about one or two weeks I may need this for production and I would like to use the official images :)

@Mik4sa I was waiting for your confirmation that the flannel versions are correct.
Once you confirm I can merge this right away.

"flannel": [
    "0.12.0", 
    "0.13.0",
    "0.14.0",
    "0.15.1"

@Mik4sa
Copy link
Contributor

Mik4sa commented Dec 9, 2022

@marosset My bad. Back then I tested successfully flannel version 0.13.0 with kube-proxy for k8s 1.23.3

@marosset
Copy link
Contributor Author

marosset commented Dec 9, 2022

/assign @jsturtevant

@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 98813c8 into kubernetes-sigs:master Dec 9, 2022
@jsturtevant
Copy link
Contributor

@Mik4sa note these are published to docker hub and are subject to docker hubs rate limiting. Typically, we see customer want to have an image in their own registry for control and stability. Another thing to note is these images only work with Dockershim which has been removed from k8s 1.23, they won't work well with containerd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants