Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade external-snapshotter to version v8.2.0 #3137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vdkotkar
Copy link
Contributor

@vdkotkar vdkotkar commented Dec 17, 2024

What this PR does / why we need it:
Upgrade external-snapshotter to version v8.2.0

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Verified that all basic snapshot operations like snapshot creation and restore are working fine with these changes.

# k get deploy -n vmware-system-csi -o yaml | grep csi-snapshotter
...
image: registry.k8s.io/sig-storage/csi-snapshotter:v8.2.0
# k create -f example-sc.yaml 
storageclass.storage.k8s.io/example-vanilla-rwo-filesystem-sc created

# k get sc
NAME                                          PROVISIONER              RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
example-vanilla-rwo-filesystem-sc (default)   csi.vsphere.vmware.com   Delete          Immediate           true                   7m59s

root@k8s-control-569-1736233714:~/vanilla-k8s-RWO-filesystem-volumes# k create -f example-pvc.yaml 
persistentvolumeclaim/example-vanilla-rwo-pvc created

# k get pvc
NAME                      STATUS    VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS                        VOLUMEATTRIBUTESCLASS   AGE
example-vanilla-rwo-pvc   Pending                                      example-vanilla-rwo-filesystem-sc   <unset>                 11s

# k get pvc
NAME                      STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                        VOLUMEATTRIBUTESCLASS   AGE
example-vanilla-rwo-pvc   Bound    pvc-5b7cd8fc-a9cf-4ba8-acdd-abd8527b1cf0   1Gi        RWO            example-vanilla-rwo-filesystem-sc   <unset>                 65s

Snapshot creation successful:

# k create -f example-snapshotclass.yaml 
volumesnapshotclass.snapshot.storage.k8s.io/example-vanilla-rwo-filesystem-snapshotclass created

# k get vsclass
NAME                                           DRIVER                   DELETIONPOLICY   AGE
example-vanilla-rwo-filesystem-snapshotclass   csi.vsphere.vmware.com   Delete           6m11s

# k create -f example-snapshot.yaml 
volumesnapshot.snapshot.storage.k8s.io/example-vanilla-rwo-filesystem-snapshot created

# k get vs
NAME                                      READYTOUSE   SOURCEPVC                 SOURCESNAPSHOTCONTENT   RESTORESIZE   SNAPSHOTCLASS                                  SNAPSHOTCONTENT                                    CREATIONTIME   AGE
example-vanilla-rwo-filesystem-snapshot   true         example-vanilla-rwo-pvc                           1Gi           example-vanilla-rwo-filesystem-snapshotclass   snapcontent-1015999f-c5e4-457f-a963-9dc7dee6326e   18s            16s

# k get vsc
NAME                                               READYTOUSE   RESTORESIZE   DELETIONPOLICY   DRIVER                   VOLUMESNAPSHOTCLASS                            VOLUMESNAPSHOT                            VOLUMESNAPSHOTNAMESPACE   AGE
snapcontent-1015999f-c5e4-457f-a963-9dc7dee6326e   true         1073741824    Delete           csi.vsphere.vmware.com   example-vanilla-rwo-filesystem-snapshotclass   example-vanilla-rwo-filesystem-snapshot   default                   13s

Snapshot restore successful:

# k create -f example-restore.yaml 
persistentvolumeclaim/example-vanilla-rwo-filesystem-restore created

# k get pvc
NAME                                     STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                        VOLUMEATTRIBUTESCLASS   AGE
example-vanilla-rwo-filesystem-restore   Bound    pvc-74c94442-18e2-4586-828e-a04d4c471ca0   1Gi        RWO            example-vanilla-rwo-filesystem-sc   <unset>                 6s
example-vanilla-rwo-pvc                  Bound    pvc-5b7cd8fc-a9cf-4ba8-acdd-abd8527b1cf0   1Gi        RWO            example-vanilla-rwo-filesystem-sc   <unset>                 4m4s

Special notes for your reviewer:

Release note:

 Upgrade external-snapshotter to version v8.2.0

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vdkotkar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2024
@vdkotkar vdkotkar force-pushed the upgrade_external_snapshotter branch from 39b3ef9 to cacc42a Compare January 7, 2025 10:55
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vdkotkar
Once this PR has been reviewed and has the lgtm label, please assign akankshapanse for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants