Retry CnsVolumeOperationRequest clean up on snapshot listing error #3144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When listing snapshots fails, the cleanup should be retried. Currently the cleanup goroutine is exited, and CnsVolumeOperationRequest count can grow without limit until the pod is restarted.
Which issue this PR fixes :
Testing done:
We had intermitent failure on apiserver request, and after that, cleanup would not run because the goroutine is exited.
This PR fixed it.
Special notes for your reviewer:
Release note: