Building arm64 admission-webhook image too #109
Conversation
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
|
||
| .PHONY: image_build_int | ||
| image_build_int: | ||
| $(BUILDX_BUILD) --load $(AMD64_ARGS) -f dockerfiles/Dockerfile -t $(WEBHOOK_IMG):$(TAG) -t $(WEBHOOK_IMG):latest |
There was a problem hiding this comment.
do you need to have a line that does this for ARM64_ARGS
There was a problem hiding this comment.
the image_build targers only build and amd64 image are are intended to be used during integration tests.
the image_build_and_push targets build both amd64 and arm64 images and we do use ARM64_ARGS in there.
I added some comment to clarify this.
Let me know if this makes sense
admission-webhook/Makefile
Outdated
| @@ -59,4 +59,4 @@ clean: cluster_clean clean_integration_tests deps_clean | |||
|
|
|||
| .PHONY: release-staging | |||
| release-staging: ## Builds and push webhook image to k8s-staging bucket | |||
| REGISTRY=$(STAGING_REGISTRY) $(MAKE) image_build image_push | |||
| REGISTRY=$(STAGING_REGISTRY) $(MAKE) image_push | |||
There was a problem hiding this comment.
this drops the build step before the push?
There was a problem hiding this comment.
I had to update the build workflow to use buildkit with --push when we are building the multi-arch image and because of this we only have 1 step now.
I'll rename to image_build_and_push for clarity
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Fixes #107
Updating the build process to build a multi-arch container image with both amd64 and arm64 flavors for the admission-webhook
/hold for CI
/sig windows
/assign @jsturtevant