Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate the control-plane taint #67

Merged

Conversation

jsturtevant
Copy link
Contributor

After kubernetes/kubernetes#107533 and kubernetes-sigs/cluster-api-provider-azure#2098 Clusters my have the taint node-role.kubernetes.io/control-plane. This is toleration is needed for the k/k e2e suite where GMSA and this script are used https://github.com/kubernetes/kubernetes/blob/8c1dc25745480b280b38933ed3532e0830f58056/test/e2e/windows/gmsa_full.go#L270

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2022
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2022
@marosset
Copy link
Contributor

marosset commented Mar 3, 2022

This should be configurable. I'm OK with having those config knobs only exist in the helm based deployments tho.

@marosset
Copy link
Contributor

marosset commented Mar 3, 2022

This should be configurable. I'm OK with having those config knobs only exist in the helm based deployments tho.

Oh - i guess it is configurable with TOLERATE_MASTER (which I didn't see until I expanded the whole file

This is needed for (some) cluster-api based deployments
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsturtevant
Copy link
Contributor Author

fyi @phillipsj for integrating this into helm chart

@k8s-ci-robot k8s-ci-robot merged commit 17b2188 into kubernetes-sigs:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants