Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make clean as --report-prefix/ is recognized as option #79

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix make clean as --report-prefix/ is recognized as option #79

merged 1 commit into from
Jul 26, 2023

Conversation

KlwntSingh
Copy link
Contributor

When running make clean, it failed with the following error:

rm: unrecognized option '--report-prefix/'
Try 'rm ./--report-prefix/' to remove the file ‘--report-prefix/’.
Try 'rm --help' for more information.
make: *** [clean] Error 1

What type of PR is this?

Bug fix

What this PR does / why we need it:

It fixes make clean in repo

Which issue(s) this PR fixes:

@KlwntSingh
Fix make clean as --report-prefix/ is recognized as option
07232b5 
When running make clean, it failed with following error
```
rm: unrecognized option '--report-prefix/'
Try 'rm ./--report-prefix/' to remove the file ‘--report-prefix/’.
Try 'rm --help' for more information.
make: *** [clean] Error 1
```
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @KlwntSingh!

It looks like this is your first PR to kubernetes-sigs/windows-operational-readiness 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/windows-operational-readiness has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @KlwntSingh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, KlwntSingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@jayunit100 jayunit100 merged commit 4804022 into kubernetes-sigs:main Jul 26, 2023
@KlwntSingh KlwntSingh mentioned this pull request Jul 27, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayunit100 jayunit100 jayunit100 approved these changes

@iXinqi iXinqi Awaiting requested review from iXinqi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KlwntSingh @k8s-ci-robot @jayunit100