Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for gmsa #328

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

jsturtevant
Copy link
Contributor

Adding scripts and setup for running gmsa in e2e tests

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2022
@jsturtevant jsturtevant force-pushed the gmsa branch 5 times, most recently from b208ac4 to 0e4e141 Compare July 6, 2022 15:11
@jsturtevant
Copy link
Contributor Author

gmsa tests passed! Will clean up and get it ready to merge

•{"msg":"PASSED [sig-windows] [Feature:Windows] GMSA Kubelet [Slow] kubelet GMSA support when creating a pod with correct GMSA credential specs passes the credential specs down to the Pod's containers","total":3,"completed":3,"skipped":6735,"failed":0}

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2022
@jsturtevant jsturtevant force-pushed the gmsa branch 2 times, most recently from de52347 to bf8897d Compare July 14, 2022 23:25
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022
@jsturtevant jsturtevant force-pushed the gmsa branch 4 times, most recently from 96f5bc7 to 65c9a51 Compare July 15, 2022 18:20
@jsturtevant jsturtevant changed the title wip: Adding support for gmsa Adding support for gmsa Jul 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

something isn't right with the gmsa job. No tests ran....

@jsturtevant
Copy link
Contributor Author

gmsa tests Passed!

the other test was the flake on [It] [sig-windows] Services should be able to create a functioning NodePort service for Windows
/retest

@marosset
Copy link
Contributor

/assign

- content: |
$ErrorActionPreference = 'Stop'
Stop-Service kubelet -Force
$$CI_VERSION="${CI_VERSION}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work for CI jobs but put PR jobs.
How should we track that? Should I open an issue in this repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opening an issue here works for me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #337

capz/gmsa/kustomization.yaml Outdated Show resolved Hide resolved
capz/gmsa/patches/machine-identity.yaml Outdated Show resolved Hide resolved
capz/gmsa/patches/vnet-peering.yaml Outdated Show resolved Hide resolved
capz/gmsa/setup-gmsa.sh Outdated Show resolved Hide resolved
capz/gmsa/ci-gmsa.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2022
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2022
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-containerd-windows-2022-extension-gmsa

@marosset
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants