-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for gmsa #328
Conversation
b208ac4
to
0e4e141
Compare
gmsa tests passed! Will clean up and get it ready to merge
|
de52347
to
bf8897d
Compare
96f5bc7
to
65c9a51
Compare
/test pull-e2e-capz-containerd-windows-2022-extension-gmsa |
something isn't right with the gmsa job. No tests ran.... |
gmsa tests Passed! the other test was the flake on |
/assign |
- content: | | ||
$ErrorActionPreference = 'Stop' | ||
Stop-Service kubelet -Force | ||
$$CI_VERSION="${CI_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work for CI jobs but put PR jobs.
How should we track that? Should I open an issue in this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opening an issue here works for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #337
Signed-off-by: James Sturtevant <jsturtevant@gmail.com> Signed-off-by: James Sturtevant <jstur@microsoft.com>
/test pull-e2e-capz-containerd-windows-2022-extension-gmsa |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding scripts and setup for running gmsa in e2e tests