Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure sdk for golang #450

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Jul 15, 2024

After switching to the Workload identity the old SDK didn't support the credentials.

This updates the SDK to use the latest version. The DefaultAzureCredential will work with both ENV variables and workload identity: https://github.com/Azure/azure-sdk-for-go/tree/sdk/azidentity/v1.7.0/sdk/azidentity#defaultazurecredential

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2024
@jsturtevant
Copy link
Contributor Author

/test ls

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

  • /test pull-e2e-capz-validate-pr-templates
  • /test pull-e2e-capz-windows-2022-extension
  • /test pull-e2e-capz-windows-2022-extension-community
  • /test pull-e2e-capz-windows-2022-extension-gmsa
  • /test pull-e2e-run-capz-sh-windows-2022-hyperv

Use /test all to run the following jobs that were automatically triggered:

  • pull-e2e-capz-windows-2022-extension
  • pull-e2e-capz-windows-2022-extension-gmsa

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

1 similar comment
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

Authentication is working but goofed up the print statement function

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

This update will work with workload identity.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@jsturtevant jsturtevant changed the title testing gmsa Update azure sdk for golang Jul 16, 2024
@jsturtevant jsturtevant marked this pull request as ready for review July 16, 2024 22:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jayunit100 July 16, 2024 22:23
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa
/hold
for test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@jsturtevant
Copy link
Contributor Author

/assign @marosset @ritikaguptams

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: GitHub didn't allow me to assign the following users: ritikaguptams.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @marosset @ritikaguptams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsturtevant
Copy link
Contributor Author

capacity error, we are hitting it often going to drop westeurope in separate PR
/test pull-e2e-capz-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

#452
/test pull-e2e-capz-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

westeurope three times in a row?!

/test pull-e2e-capz-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@marosset
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 66e3cb0 into kubernetes-sigs:master Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants