-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure sdk for golang #450
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ls |
@jsturtevant: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-e2e-capz-windows-2022-extension-gmsa |
1 similar comment
/test pull-e2e-capz-windows-2022-extension-gmsa |
/test pull-e2e-capz-windows-2022-extension-gmsa |
Authentication is working but goofed up the print statement function |
/test pull-e2e-capz-windows-2022-extension-gmsa |
This update will work with workload identity. Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
/test pull-e2e-capz-windows-2022-extension-gmsa |
/assign @marosset @ritikaguptams |
@jsturtevant: GitHub didn't allow me to assign the following users: ritikaguptams. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
capacity error, we are hitting it often going to drop westeurope in separate PR |
#452 |
westeurope three times in a row?! /test pull-e2e-capz-windows-2022-extension-gmsa |
/hold cancel |
/lgtm |
After switching to the Workload identity the old SDK didn't support the credentials.
This updates the SDK to use the latest version. The
DefaultAzureCredential
will work with both ENV variables and workload identity: https://github.com/Azure/azure-sdk-for-go/tree/sdk/azidentity/v1.7.0/sdk/azidentity#defaultazurecredential