Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set-version command #818

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add set-version command #818

merged 2 commits into from
Feb 19, 2024

Conversation

chlunde
Copy link
Contributor

@chlunde chlunde commented Jan 12, 2024

set-version takes a single dependency and sets it to a specific version.

This could be used in a script or pipeline based on the output from zeitgeist export, or for manual upgrade/downgrade.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Updates #810

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The new command set-version can be used to upgrade a single dependency, for manual use or as part of a pipeline to automatically update dependencies.

@chlunde
Add set-version command
3e5820e 
set-version takes a single dependency and sets it to a specific version.

This could be used in a script or pipeline based on the output from
zeitgeist export, or for manual upgrade/downgrade.

Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jrsapi January 12, 2024 14:50
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chlunde. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 12, 2024
@chlunde chlunde marked this pull request as ready for review January 15, 2024 07:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2024
cpanato
cpanato reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2024
@chlunde chlunde mentioned this pull request Jan 15, 2024
Closed
Pluies
Pluies reviewed Jan 16, 2024
View reviewed changes
@chlunde
set-version: Idempotent upgrades, don't fail if already updated
84c935d 
Also fix golangci-lint shadowing lint error (dependency package vs.
variable).

Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
@cpanato
Copy link
Member

cpanato commented Feb 17, 2024

/approve
/hold for @Pluies

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2024
@Pluies
Copy link
Contributor

Pluies commented Feb 19, 2024

Good stuff, thank you @chlunde ! :)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chlunde, cpanato, Pluies

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Pluies
Copy link
Contributor

Pluies commented Feb 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@cpanato
Copy link
Member

cpanato commented Feb 19, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit c3331d8 into kubernetes-sigs:master Feb 19, 2024
7 checks passed
@chlunde chlunde deleted the set-version branch February 19, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pluies Pluies Pluies left review comments

@cpanato cpanato cpanato left review comments

@jrsapi jrsapi Awaiting requested review from jrsapi

@salaxander salaxander Awaiting requested review from salaxander

@cici37 cici37 Awaiting requested review from cici37

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@Pluies Pluies

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chlunde @k8s-ci-robot @cpanato @Pluies