isolate remote zeitgeist functionality/dependencies to separate command/package #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
|
/hold to double/triple check :) /assign @saschagrunert @xmudrii @Pluies @liggitt |
k8s-ci-robot
added
the
do-not-merge/hold
saschagrunert
approved these changes
Feb 21, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FROM PR #547
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Isolates remote functionality into a subpackage and separate command, so that downstreams relying on the main zeitgeist command to verify local files only don't take dependencies on large numbers of remote libraries (github, gitlab, aws, etc).
My scans of in-project use looked like we only relied on the local dependencies.yaml with no upstreams specified (xref #543 (comment))
Which issue(s) this PR fixes:
FIxes: #543
Best reviewed commit-by-commit
Does this PR introduce a user-facing change?