Skip to content

Commit

Permalink
api: add user namespaces field to NodeRuntimeHandlerFeatures
Browse files Browse the repository at this point in the history
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>

Kubernetes-commit: 86240aaca17e0bfbdbaec78bf2604f8623c73615
  • Loading branch information
haircommander authored and k8s-publishing-bot committed May 31, 2024
1 parent fc8a03c commit 0787ff7
Show file tree
Hide file tree
Showing 8 changed files with 1,046 additions and 992 deletions.
2,016 changes: 1,026 additions & 990 deletions core/v1/generated.pb.go

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions core/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion core/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -5877,7 +5877,10 @@ type NodeRuntimeHandlerFeatures struct {
// +featureGate=RecursiveReadOnlyMounts
// +optional
RecursiveReadOnlyMounts *bool `json:"recursiveReadOnlyMounts,omitempty" protobuf:"varint,1,opt,name=recursiveReadOnlyMounts"`
// Reserved: UserNamespaces *bool (varint 2, for consistency with CRI API)
// UserNamespaces is set to true if the runtime handler supports UserNamespaces, including for volumes.
// +featureGate=UserNamespacesSupport
// +optional
UserNamespaces *bool `json:"userNamespaces,omitempty" protobuf:"varint,2,opt,name=userNamespaces"`
}

// NodeRuntimeHandler is a set of runtime handler information.
Expand Down Expand Up @@ -6029,6 +6032,7 @@ type NodeStatus struct {
Config *NodeConfigStatus `json:"config,omitempty" protobuf:"bytes,11,opt,name=config"`
// The available runtime handlers.
// +featureGate=RecursiveReadOnlyMounts
// +featureGate=UserNamespacesSupport
// +optional
// +listType=atomic
RuntimeHandlers []NodeRuntimeHandler `json:"runtimeHandlers,omitempty" protobuf:"bytes,12,rep,name=runtimeHandlers"`
Expand Down
1 change: 1 addition & 0 deletions core/v1/types_swagger_doc_generated.go
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,7 @@ func (NodeRuntimeHandler) SwaggerDoc() map[string]string {
var map_NodeRuntimeHandlerFeatures = map[string]string{
"": "NodeRuntimeHandlerFeatures is a set of runtime features.",
"recursiveReadOnlyMounts": "RecursiveReadOnlyMounts is set to true if the runtime handler supports RecursiveReadOnlyMounts.",
"userNamespaces": "UserNamespaces is set to true if the runtime handler supports UserNamespaces, including for volumes.",
}

func (NodeRuntimeHandlerFeatures) SwaggerDoc() map[string]string {
Expand Down
5 changes: 5 additions & 0 deletions core/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion testdata/HEAD/core.v1.Node.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@
{
"name": "nameValue",
"features": {
"recursiveReadOnlyMounts": true
"recursiveReadOnlyMounts": true,
"userNamespaces": true
}
}
]
Expand Down
Binary file modified testdata/HEAD/core.v1.Node.pb
Binary file not shown.
1 change: 1 addition & 0 deletions testdata/HEAD/core.v1.Node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ status:
runtimeHandlers:
- features:
recursiveReadOnlyMounts: true
userNamespaces: true
name: nameValue
volumesAttached:
- devicePath: devicePathValue
Expand Down

0 comments on commit 0787ff7

Please sign in to comment.