Skip to content

Commit

Permalink
Merge pull request #482 from aleksandra-malinowska/cherry-pick-safety…
Browse files Browse the repository at this point in the history
…-net

Extra checks when pushing an image to gcr repository
  • Loading branch information
mwielgus committed Nov 17, 2017
2 parents 624ba01 + 74a8b57 commit 818f991
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
2 changes: 1 addition & 1 deletion cluster-autoscaler/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ ifndef REGISTRY
$(ERR)
endif
docker build --pull -t ${REGISTRY}/cluster-autoscaler:${TAG} .
gcloud docker -- push ${REGISTRY}/cluster-autoscaler:${TAG}
./push_image.sh ${REGISTRY}/cluster-autoscaler:${TAG}

clean:
rm -f cluster-autoscaler
Expand Down
35 changes: 35 additions & 0 deletions cluster-autoscaler/push_image.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/bin/bash

# Copyright 2017 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

IMAGE_TO_PUSH=$1
if [ -z $IMAGE_TO_PUSH ]; then
echo No image passed
exit 1
fi

echo "About to push image $IMAGE_TO_PUSH"
read -r -p "Are you sure? [y/N] " response
if [[ "$response" =~ ^([yY])+$ ]]; then
gcloud docker -- pull $IMAGE_TO_PUSH
if [ $? -eq 0 ]; then
echo $IMAGE_TO_PUSH already exists
exit 1
fi
gcloud docker -- push $IMAGE_TO_PUSH
else
echo Aborted
exit 1
fi

0 comments on commit 818f991

Please sign in to comment.