Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify vendor code in presubmit #6267

Closed
sophieliu15 opened this issue Nov 9, 2023 · 6 comments
Closed

Verify vendor code in presubmit #6267

sophieliu15 opened this issue Nov 9, 2023 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@sophieliu15
Copy link

Which component are you using?: VPA

Which component hosted in this repository is this a feature for?: All components

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
Currently there is no good way to verify the integrity of modules under vendor directory. For example, someone could upgrade go version or go module version; update dependencies; perform go mod vendor; hand edit a go file under vendor and add a new function. The tempered vendor file will be buried in all the vendor changes.

You could look at all the vendor file change and verify individually but it is pretty time consuming and unrealistic.

Describe the solution you'd like.: Add a verification under hack/ directory to verify vendor code integrity. Similar to https://github.com/kubernetes/kubernetes/blob/master/hack/verify-vendor.sh

Describe any alternative solutions you've considered.: Ideally go mod verify should do this but it is not happening: golang/go#27348

Additional context.:

@sophieliu15 sophieliu15 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2024
@Shubham82
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 5, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2024
@Shubham82
Copy link
Contributor

Hi @sophieliu15, JFI we removed the Cluster Autoscaler vendor directory in favor of Go modules,
Here is the PR for it: #6572

@Shubham82
Copy link
Contributor

Closing this issue, as it is resolved by the PR #6572
/close

@k8s-ci-robot
Copy link
Contributor

@Shubham82: Closing this issue.

In response to this:

Closing this issue, as it is resolved by the PR #6572
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants