-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VPA Kubernetes dependencies to 1.23.4 #4737
Update VPA Kubernetes dependencies to 1.23.4 #4737
Conversation
Welcome @yankay! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yankay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
921c0af
to
dfd79fa
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
dfd79fa
to
8bf00aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refresh. Mostly looks reasonable but there is a test failure, please fix it.
HI @jbartosik . The CI script may have some issue. It force “GO111MODULE=off” . There is a PR try to fix it : #4738. |
@yankay: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you for the PR. Unfortunately, PRs this big cannot be reviewed so we can only accept it from the project owners. As VPA or CA oftentimes run with quite significant permissions, merging impossible to review PRs from non-owners creates a significant security risk. At the same time I fully understand the need for godeps update and deeply appreciate your effort. With that, i'm closing this PR. |
Update VPA Kubernetes dependencies to 1.23.4. to fix the CVE ISSUE:#4673
Signed-off-by: Kay Yan kay.yan@daocloud.io