Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VPA Kubernetes dependencies to 1.23.4 #4737

Conversation

yankay
Copy link
Member

@yankay yankay commented Mar 15, 2022

Update VPA Kubernetes dependencies to 1.23.4. to fix the CVE ISSUE:#4673

Signed-off-by: Kay Yan kay.yan@daocloud.io

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yankay!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yankay
To complete the pull request process, please assign jbartosik after the PR has been reviewed.
You can assign the PR to them by writing /assign @jbartosik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay yankay force-pushed the Update-VPA-Kubernetes-dependencies-to-1.23.4 branch 5 times, most recently from 921c0af to dfd79fa Compare March 15, 2022 12:20
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the Update-VPA-Kubernetes-dependencies-to-1.23.4 branch from dfd79fa to 8bf00aa Compare March 15, 2022 12:28
Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refresh. Mostly looks reasonable but there is a test failure, please fix it.

@yankay
Copy link
Member Author

yankay commented Mar 28, 2022

Thanks for the refresh. Mostly looks reasonable but there is a test failure, please fix it.

HI @jbartosik . The CI script may have some issue. It force “GO111MODULE=off” .

There is a PR try to fix it : #4738.

@k8s-ci-robot
Copy link
Contributor

@yankay: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022
@mwielgus
Copy link
Contributor

mwielgus commented Apr 4, 2022

Thank you for the PR. Unfortunately, PRs this big cannot be reviewed so we can only accept it from the project owners. As VPA or CA oftentimes run with quite significant permissions, merging impossible to review PRs from non-owners creates a significant security risk. At the same time I fully understand the need for godeps update and deeply appreciate your effort.
Please coordinate with @jbartosik to take reviewable bits from your PR and generate the vendor changes by the owner.

With that, i'm closing this PR.

@mwielgus mwielgus closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants