VPA: make parameters oomBumpUpRatio and oomMinBumpUp configurable

[navinjoy]

Which component this PR applies to?

vertical-pod-autoscaler/recommender

What type of PR is this?

/kind feature

What this PR does / why we need it:

This is a small change for adding the parameters for oomBumpUpRatio and oomMinBumpUp.

We have executed multiple Load tests for VPA and since VPA has to terminate the pods and new recommendations are applied during recreation of a pod and when OOM occurs during load, 20% increase is not sufficient. Therefore we want this to be configurable and for our service and tests we did we doubled the memory. Having these flags configurable will help for different types of services.

Which issue(s) this PR fixes:

No issue exists for this.

Special notes for your reviewer:

Validated the change in my local dev cluster k8s 1.25.

% kubectl get node
NAME                       STATUS   ROLES           AGE   VERSION
vpa-k8s125-control-plane   Ready    control-plane   24h   v1.25.0

% k describe deploy vpa-recommender
Name:                   vpa-recommender
Namespace:              kube-system
CreationTimestamp:      Wed, 19 Oct 2022 16:36:22 -0700
Labels:                 <none>
Annotations:            deployment.kubernetes.io/revision: 3
Selector:               app=vpa-recommender
Replicas:               1 desired | 1 updated | 1 total | 1 available | 0 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  25% max unavailable, 25% max surge
Pod Template:
  Labels:           app=vpa-recommender
  Service Account:  vpa-recommender
  Containers:
   recommender:
    Image:      <updated image with change>
    Port:       8942/TCP
    Host Port:  0/TCP
    Args:
      --oom-bump-up-ratio=1.5
      --oom-min-bump-up=524288000

Does this PR introduce a user-facing change?

NA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NA

[jbartosik]

Please mention those flags in README/Starting multiple recommenders

[navinjoy]

@jbartosik I have addressed the review comments, could you please check if it looks good now. Thank you.

[jbartosik]

I think this is close to ready

[navinjoy]

@jbartosik please review when you get a chance.

[jbartosik]

I was unavailable for a while.

Please add a release note to the description.

[jbartosik]

Also please fix the presubmit error:

vertical-pod-autoscaler/README.md:298:86: "occured" is a misspelling of "occurred"

[voelzmo]

A few suggestions regarding the wording for the sake of consistency and clarity.

[navinjoy]

@jbartosik @voelzmo I committed the suggested changes for the PR. Can you please review and approve this. Thank you.

[voelzmo]

Thanks for including the wording changes! At this point, I'm wondering if this is good to go, or if we should have some tests showing that specifying a custom value for oomMinBumpUp and oomBumpUpRatio actually does what it should do? @jbartosik, WDYT? Unfortunately, I didn't see any tests for the other cases in which we moved out configuration like this from being hardcoded into a flag (like e.g. targetCPUPercentile)

[navinjoy]

@jbartosik could you please review and let me know if its ready to merge. Thank you.

[jbartosik]

@navinjoy looks good to me. Can you rebase the PR?

[jbartosik]

@navinjoy please squash commits and rebase the PR

[navinjoy]

Sure will do that. I was out last 2weeks.

[jbartosik]

Thanks, please ping me when you do

[jbartosik]

Do you think you can squash & rebase this week? I'd like to resume working on the release next week

[navinjoy]

@jbartosik I will do this today. Got struck with my tasks.

[navinjoy]

@jbartosik please check if the PR is ready to merge.

[jbartosik]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, navinjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS [jbartosik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment