cluster-autoscaler: Add option to disable scale down of unready nodes #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/cluster-autoscaler
size/M
|
Also linking the the initial this PR, which is now closed due to inactivity: |
x13n
reviewed
Feb 28, 2023
cluster-autoscaler/core/scaledown/eligibility/eligibility_test.go
Outdated
Show resolved
Hide resolved
|
/assign |
gregth
force-pushed
the
feature-disable-unready-scaledown
branch
from
64afc48 to
8b01f51
Compare
x13n
requested changes
Mar 3, 2023
cluster-autoscaler/core/scaledown/eligibility/eligibility_test.go
Outdated
Show resolved
Hide resolved
|
Thanks, looks good to me now, can you squash the commits? |
Add flag '--scale-down-unready-enabled' to enable or disable scale-down of unready nodes. Default value set to true for backwards compatibility (i.e., allow scale-down of unready nodes). Signed-off-by: Grigoris Thanasoulas <gregth@arrikto.com>
gregth
force-pushed
the
feature-disable-unready-scaledown
branch
from
2906618 to
6cf8c32
Compare
|
@x13n thanks, squashed the commits and force-pushed. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gregth, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag '--scale-down-unready-enabled' to enable or disable scale-down of unready nodes. Default value set to true for backwards compatibility (i.e., allow scale-down of unready nodes).
Which component this PR applies to?
Cluster Autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the option to disable scale down for unready nodes.
There are cases where a user may not want the unready nodes to be removed from a cluster.
As an example, but not limited to, this might be useful in case a node is unreachable for a period of time and local data live there, the node shall remain in the cluster, and possibly an admin may want to take any actions for recovering it.
Which issue(s) this PR fixes:
Fixes #4876.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: