Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pods with emptydir volume in memory be evictable #5551

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

askoriy
Copy link
Contributor

@askoriy askoriy commented Feb 28, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, pods with in-memory storage are considered as having local storage and are not evictable. This prevents cluster autoscaling to down-scale the node if such pods are present.

In-memory storage is widely used for organizing init or sidecar container communication and in the vast majority of cases should not contain critical data to be lost (see details explanation at #3984).
If the new default behavior is not desired then annotation could be added: "cluster-autoscaler.kubernetes.io/safe-to-evict": "false"

Which issue(s) this PR fixes:

Fixes #3984, #2048

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Pods having `emptyDir` volumes with `medium: Memory` are not considered to have local storage and therefore are evictable

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 28, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: askoriy / name: Oleksandr Skoryi (946189f)

@k8s-ci-robot k8s-ci-robot requested a review from x13n February 28, 2023 19:03
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @askoriy!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 28, 2023
@towca
Copy link
Collaborator

towca commented Mar 24, 2023

This isn't a backwards compatible change (CA would start removing existing pods/nodes that were previously unremovable), so I wouldn't backport it anywhere. It should be fine for a new minor release, and it definitely makes sense. Thanks for the contribution!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: askoriy, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit dcf8f82 into kubernetes:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emptyDir/Memory volume shouldn't prevent pod from eviction
3 participants