Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudprovider/externalgrpc): GetOptions returns MaxNodeProvisionTime as 0 seconds #5936

Commits on Jul 13, 2023

  1. fix(cloudprovider/externalgrpc): GetOptions returns `MaxNodeProvisi…

    …onTime` as 0 seconds
    
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    
    chore(cloudprovider/externalgrpc): fix CI failing because of wrong header
    - CI complains if I remove or change the copyright header
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    
    chore(cloudprovider/externalgrpc): fix spacing for license headers
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    
    chore(cloudprovider/externalgrpc): remove extra space in copyright header
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    
    test(cloudprovider/externalgrpc): add assert for `MaxNodeProvisionTime`
    - add extra assert for err test case
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    
    fix: duplicate line
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    
    docs: add example with `MaxNodeProvisionTime`
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    
    refactor: return `MaxNodeProvisionTime` from `NodeGroupGetOptions` in response
    Signed-off-by: vadasambar <surajrbanakar@gmail.com>
    vadasambar committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6df52ec View commit details
    Browse the repository at this point in the history