-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug with missing taint translation layer between AWS EKS format and Kubernetes format #6482
Conversation
… and Kubernetes format Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Welcome @wcarlsen! |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/assign @gjtempleton @drmorr0 Can (one of) you take a look? |
So anything we can do to get the ball rolling on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor comments, will approve when those are fixed.
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
/lgtm |
/approved |
Should this be
|
d'oh. thank you. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drmorr0, wcarlsen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The fix is included in release 1.31.0 🥳 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a bug between AWS EKS API understanding of Kubernetes taints and normal Kubernetes understanding of taints by introducing a translation method. Since the AWS API response when calling DescribeNodegroup have taints in the format of NO_SCHEDULE instead of NoSchedule as an example.
Which issue(s) this PR fixes:
Fixes #6481
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: