-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(chart): Add support for civo provider #6656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Add support for civo provider #6656
Conversation
|
Welcome @rbnis! |
Hi @rbnis. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
@rbnis, please resolve the merge conflict. |
9ba8669
to
66a343d
Compare
The following parameters are required: | ||
|
||
- `cloudProvider=civo` | ||
- `autoscalingGroups=...` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any template enforcement of this requirement (let me know if I'm missing something). Do you think we can add something that will integrate w/ the existing template spaghetti?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented this like the hetzner provider, there is also no validation.
But surely I could add an validation like this:
charts/cluster-autoscaler/templates/_validation.tpl
:
{{- if eq .Values.cloudProvider "civo" -}}
{{- if gt (len .Values.autoscalingGroups) 0 -}}
When cloudProvider is set to "civo", autoscalingGroups must be provided.
{{- end -}}
{{- end -}}
66a343d
to
cec4cdd
Compare
cc @jackfrancis @gjtempleton |
d69e129
to
3b5b137
Compare
Latest push is just a rebase again. |
/lgtm |
cc @gjtempleton @jackfrancis Thanks! |
/lgtm /assign @gjtempleton |
cc @gjtempleton Thanks! |
@rbnis could you please revise the chart version one more time, hope this will be the last time. Sorry, to revise the chart version once again. |
3b5b137
to
c246345
Compare
@Shubham82 |
Thanks @rbnis |
cc @gjtempleton, |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, rbnis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for the Civo Cloud provider to the helm chart.
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: