Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CA 1.28 #6596 cherry-pick] Remove shadow err variable in deleteCreatedNodesWithErros func #6758

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[CA 1.28 #6596 cherry-pick] Remove shadow err variable in deleteCreatedNodesWithErros func #6758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cluster-autoscaler/core/static_autoscaler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,8 @@ func (a *StaticAutoscaler) deleteCreatedNodesWithErrors() (bool, error) {
if nodeGroup == nil {
err = fmt.Errorf("node group %s not found", nodeGroupId)
} else {
opts, err := nodeGroup.GetOptions(a.NodeGroupDefaults)
var opts *config.NodeGroupAutoscalingOptions
opts, err = nodeGroup.GetOptions(a.NodeGroupDefaults)
if err != nil {
klog.Warningf("Failed to get node group options for %s: %s", nodeGroupId, err)
continue
Expand Down
Loading