Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/aws asg unsafe decommission 5829 #6818

Closed
wants to merge 2 commits into from
Closed

Fix/aws asg unsafe decommission 5829 #6818

wants to merge 2 commits into from

Commits on May 10, 2024

  1. fix: Handle placeholder instance decommission safely in AWS ASGs 

    This merge resolves the issue where the Kubernetes Cluster Autoscaler incorrectly decommissions actual instances instead of placeholders within AWS ASGs. The fix ensures that only placeholders are considered for scaling down when recent scaling activities fail, thereby preventing the accidental removal of active nodes. Enhanced unit tests and checks are included to ensure robustness.

Fixes #5829
    @ruiscosta
    ruiscosta committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fb69323 View commit details
    Browse the repository at this point in the history

  2. fix: Handle placeholder instance decommission safely in AWS ASGs 

    This merge resolves the issue where the Kubernetes Cluster Autoscaler incorrectly decommissions actual instances instead of placeholders within AWS ASGs. The fix ensures that only placeholders are considered for scaling down when recent scaling activities fail, thereby preventing the accidental removal of active nodes. Enhanced unit tests and checks are included to ensure robustness.

Fixes #5829
    @ruiscosta
    ruiscosta committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9dfbb4d View commit details
    Browse the repository at this point in the history