Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPA: Add tests for selfRegistration() and filterVPAs() #6910

Merged
merged 2 commits into from
Jun 19, 2024
Merged

VPA: Add tests for selfRegistration() and filterVPAs() #6910

merged 2 commits into from
Jun 19, 2024

Commits on Jun 10, 2024

  1. VPA: Add tests for selfRegistration() and filterVPAs() 

    I'm working on another PR
(kubernetes#6788) and realised that
those changes will be touching code that is untested.

I decided to go back and add some tests before continuing work in that
PR.
    @adrianmoisey
    adrianmoisey committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    306e735 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Simplify test with ElementsMatch 

    https://pkg.go.dev/github.com/stretchr/testify@v1.9.0/assert#ElementsMatch
    @adrianmoisey
    adrianmoisey committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9c0941f View commit details
    Browse the repository at this point in the history