Add documentation regarding best-effort-atomic-scale-up ProvReq class #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
area/cluster-autoscaler
size/M
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
3 times, most recently
from
f1b25ff
to
61d17f0
Compare
|
/lgmt |
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
from
61d17f0
to
dbd110e
Compare
Shubham82
reviewed
Aug 2, 2024
cluster-autoscaler/FAQ.md
Outdated
| * __Reservation from other ProvReqs (if scale up request succeeded)__: Reserves this capacity for the ProvisioningRequest for 10 minutes, preventing other ProvReqs from using it. | ||
|
|
||
| * __Condition Updates__: | ||
| Adds a Accepted=True condition when ProvReq is accepted by ClusterAutoscaler. |
There was a problem hiding this comment.
looks good to me, just a small nit, can we mention these conditions in a numbered list, because currently it is showing in a paragraph?
There was a problem hiding this comment.
Something like this:
- Add a
Accepted=Truecondition when ProvReq is accepted by ClusterAutoscaler. - Add a
Provisioned=Truecondition to the ProvReq if the node group scale up request is successful. - Add a
BookingExpired=Truecondition when the 10-minute reservation period expires.
@yaroslava-serdiuk, WDYT?
There was a problem hiding this comment.
Good point, thanks! Markdown adds a, b, c instead of numbers, so I added bullet points instead.
There was a problem hiding this comment.
Markdown adds a, b, c instead of numbers, so I added bullet points instead.
@yaroslava-serdiuk, The changes look good to me.
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
4 times, most recently
from
0fa761e
to
f9bedeb
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cc @towca |
towca
reviewed
Aug 20, 2024
k8s-ci-robot
added
the
needs-rebase
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
from
f9bedeb
to
3a53af7
Compare
k8s-ci-robot
removed
the
lgtm
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
from
3a53af7
to
416ddfc
Compare
k8s-ci-robot
removed
the
needs-rebase
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
from
416ddfc
to
da44e51
Compare
towca
reviewed
Sep 11, 2024
|
/lgtm Feel free to unhold if you don't want to address the nit. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: towca, yaroslava-serdiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Shubham82
suggested changes
Sep 11, 2024
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
from
da44e51
to
544335c
Compare
k8s-ci-robot
removed
the
lgtm
yaroslava-serdiuk
force-pushed
the
provreq-faq
branch
from
544335c
to
23f29fb
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
#6815