Make ds pods eviction best effort when draining empty nodes(nodes wit…

[damikag]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR makes the daemon set pod eviction in empty nodes(nodes without user pods), best effort attempt. Now when draining empty nodes, autoscaler will create eviction objects for ds pods but will not wait for them to fully drain.

Before this PR when --drain-priority-config is set, autoscaler waited until draining ds pods in empty nodes. Now although --drain-priority-config is set, autoscaler will not wait until all the ds pods get evicted in empty nodes.

This change is introduced reduce the effect of --drain-priority-config to scale down throughput.

This PR do not change the behavior of clusters where --drain-priority-config is not set.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

For clusters with --drain-priority-config set, behavior of draining empty nodes will change.

[k8s-ci-robot]

Hi @damikag. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[x13n]

Looks like the tests need updating as well.

[x13n]

Oh, I didn't notice the updated version. Looks good now.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damikag, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment