Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging in recommender, updater, and target components #7294

Merged
merged 19 commits into from
Oct 24, 2024
Merged

Refactor logging in recommender, updater, and target components #7294

merged 19 commits into from
Oct 24, 2024

Conversation

omerap12
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To align the logging with the best practices and guidelines established within the Kubernetes ecosystem.

Which issue(s) this PR fixes:

As part of #6905, I'm splitting this into multiple PRs rather than submitting a single large PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @omerap12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2024
@adrianmoisey
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@adrianmoisey
Copy link
Member

Hey @jbartosik, can you approve this?
/assign jbartosik

@kwiesmueller
Copy link
Member

Cool to see structured logging is an option now!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@omerap12
Refactor logging in recommender, updater, and target components
13b6d90 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 force-pushed the logging-vpa-routines-updater-target branch from 89e5cab to 13b6d90 Compare September 25, 2024 08:11
@omerap12 @adrianmoisey
Update vertical-pod-autoscaler/pkg/recommender/routines/recommender.go
6680809 
Co-authored-by: Adrian Moisey <adrian@changeover.za.net>
@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Oct 18, 2024

/unassign @jbartosik
/assign

@k8s-ci-robot k8s-ci-robot assigned voelzmo and unassigned jbartosik Oct 18, 2024
omerap12 and others added 3 commits October 18, 2024 15:42
@omerap12 @voelzmo
using klog.KRef
e100ac1 
Co-authored-by: Marco Voelz <voelzmo@users.noreply.github.com>
@omerap12 @voelzmo
using klog.KRef
8297255 
Co-authored-by: Marco Voelz <voelzmo@users.noreply.github.com>
@omerap12
Use ErrorS
f37f0dc 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 force-pushed the logging-vpa-routines-updater-target branch from b28fd60 to f37f0dc Compare October 18, 2024 12:49
omerap12 and others added 2 commits October 18, 2024 15:50
@omerap12 @voelzmo
using klog.KRef
0e9193f 
Co-authored-by: Marco Voelz <voelzmo@users.noreply.github.com>
@omerap12
Change signature
6b8beaf 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Copy link
Member Author

Thanks for going through all the files! A few small patches to add more context.

Also in this change: there's a few occasions of klog.Warningf, could you also take care of those, please? Thanks!

Thanks for your review!
Regarding klog.Warningf, there is no klog.WarningS so I'm converting all klog.Warningf to klog.V(0).InfoS is that ok? (please see here)

@omerap12
add vpa to func signature
c72781d 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 mentioned this pull request Oct 18, 2024
Merged
@omerap12
Fix spacing issue in GetUpdatePriority function
78d0629 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
use klog.KRef
e694e09 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Refactor logging statements to use klog.V(0).InfoS() instead of klog.…
16272cb 
…Warningf().

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Refactor logging statements to use klog.V(0).InfoS() instead of klog.…
65b7c00 
…Warningf().

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@voelzmo
Copy link
Contributor

voelzmo commented Oct 22, 2024

Thanks for going through all the files! A few small patches to add more context.
Also in this change: there's a few occasions of klog.Warningf, could you also take care of those, please? Thanks!

Thanks for your review! Regarding klog.Warningf, there is no klog.WarningS so I'm converting all klog.Warningf to klog.V(0).InfoS is that ok? (please see here)

That sounds good to me. Thanks for the pointer to the original discussion!

@omerap12
Copy link
Member Author

Thanks for going through all the files! A few small patches to add more context.
Also in this change: there's a few occasions of klog.Warningf, could you also take care of those, please? Thanks!

Thanks for your review! Regarding klog.Warningf, there is no klog.WarningS so I'm converting all klog.Warningf to klog.V(0).InfoS is that ok? (please see here)

That sounds good to me. Thanks for the pointer to the original discussion!

No problem :)
Updated.

@voelzmo
Copy link
Contributor

voelzmo commented Oct 22, 2024

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@omerap12 omerap12 requested a review from voelzmo October 22, 2024 09:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Oct 24, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerap12, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e90519a into kubernetes:master Oct 24, 2024
7 checks passed
@voelzmo voelzmo mentioned this pull request Nov 27, 2024
Merged
@ialidzhikov ialidzhikov mentioned this pull request Dec 4, 2024
Merged
@adrianmoisey adrianmoisey mentioned this pull request Dec 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmoisey adrianmoisey adrianmoisey left review comments

@krzysied krzysied Awaiting requested review from krzysied

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

@voelzmo voelzmo Awaiting requested review from voelzmo

Assignees

@adrianmoisey adrianmoisey

@voelzmo voelzmo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@omerap12 @k8s-ci-robot @adrianmoisey @kwiesmueller @voelzmo @jbartosik