Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changelog for v5.0.0 #313

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Conversation

roycaihw
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2017
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Could you update the format for the "breaking changes" section to be consistent with the rest of the doc?

Also, could you update the header to "v5.0.0", currently it's "# HEAD (changes that will go into v5)".

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/50404](https://github.com/kubernetes/kubernetes/pull/50404)

* Extend SetHeader Requests method ito accept multiple values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this entry? It's to trivial to be mentioned in changelog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and squashed

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/50639](https://github.com/kubernetes/kubernetes/pull/50639)

* Add a heap to client-go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to "Adding priority queue support to informer cache."? That's the main use case.

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/39587](https://github.com/kubernetes/kubernetes/pull/39587)

* Make it possible to allow discovery errors for controllers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this one?

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/39173](https://github.com/kubernetes/kubernetes/pull/39173)

* OpenAPI downloads protobuf rather than Json to improve performance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move it to the "breaking change" section?

Could you also update the text to "The discovery client now fetches the protobuf encoded OpenAPI schema and returns openapi_v2.Document"?

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/50708](https://github.com/kubernetes/kubernetes/pull/50708)

* Copy list expansions for DaemonSet, Deployment, ReplicaSet, and StatefulSet to apps/v1beta2 from extensions/v1beta1 and apps/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this entry?

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/49370](https://github.com/kubernetes/kubernetes/pull/49370)

* The 504 timeout error was returning a JSON error body that indicated it was a 500. The body contents now correctly report a 500 error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this entry?

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/49678](https://github.com/kubernetes/kubernetes/pull/49678)

* Add a new API object apps/v1beta2.ReplicaSet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this entry?

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/49238](https://github.com/kubernetes/kubernetes/pull/49238)

* Adding type apps/v1beta2.DaemonSet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this entry?

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/48746](https://github.com/kubernetes/kubernetes/pull/48746)

* Add PriorityClass API object under new "scheduling" API group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new API version scheduling/v1alpha1

CHANGELOG.md Outdated

* [https://github.com/kubernetes/kubernetes/pull/48377](https://github.com/kubernetes/kubernetes/pull/48377)

* The generic RESTClient type (`k8s.io/client-go/rest`) no longer exposes `LabelSelectorParam` or `FieldSelectorParam` methods - use `VersionedParams` with `metav1.ListOptions` instead. The `UintParam` method has been removed. The `timeout` parameter will no longer cause an error when using `Param()`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this entry to breaking changes?

CHANGELOG.md Outdated

* Helper functions in pkg/api and pkg/apis are also removed. They are planned to be exported in other repos. The issue is tracked [here](https://github.com/kubernetes/kubernetes/issues/48209#issuecomment-314537745). During the transition, you'll have to copy the helper functions to your projects.

* The discovery client now fetches the protobuf encoded OpenAPI schema and returns `openapi\_v2.Document`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ""

@caesarxuchao
Copy link
Member

lgtm. Thanks a lot! I'll create the tag and then merge.

@caesarxuchao caesarxuchao merged commit 271cb50 into kubernetes:master Oct 20, 2017
@nikhita nikhita mentioned this pull request Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants